Require confirmation and block deleting library actions still referenced by node groups.

2026-07-20 21:00:24 +02:00
parent d188ca41b8
commit be255341e5
5 changed files with 217 additions and 0 deletions
@@ -66,6 +66,48 @@ func TestNodeActionGroupsRoundTrip(t *testing.T) {
 	}
 }

+func TestLibraryActionInUse(t *testing.T) {
+	store := NodeActionGroupStore{
+		Groups: []NodeActionGroup{
+			{
+				ID:     "g1",
+				NodeID: "n1",
+				Name:   "Nightly",
+				Items: []NodeActionItem{
+					{
+						ID:              "lib-item",
+						Source:          ActionItemSourceLibrary,
+						LibraryActionID: "custom-1",
+					},
+					{
+						ID:     "local-item",
+						Source: ActionItemSourceLocal,
+						Name:   "Echo",
+						Kind:   ActionKindShell,
+						Body:   "echo hi",
+					},
+				},
+			},
+		},
+	}
+	if !LibraryActionInUse(store, "custom-1") {
+		t.Fatal("expected library action custom-1 to be in use")
+	}
+	if LibraryActionInUse(store, "other") {
+		t.Fatal("expected unrelated action not in use")
+	}
+	store.Groups[0].Items[0] = NodeActionItem{
+		ID:     "cloned",
+		Source: ActionItemSourceLocal,
+		Name:   "Echo host",
+		Kind:   ActionKindShell,
+		Body:   "echo",
+	}
+	if LibraryActionInUse(store, "custom-1") {
+		t.Fatal("expected cloned local item not to count as in use")
+	}
+}
+
 func TestIsScheduleDueInterval(t *testing.T) {
 	now := time.Date(2026, 7, 19, 12, 0, 0, 0, time.Local)
 	group := NodeActionGroup{